Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MENU_SCROLL in every relevant menu #50928

Open
Brambor opened this issue Aug 20, 2021 · 0 comments
Open

Use MENU_SCROLL in every relevant menu #50928

Brambor opened this issue Aug 20, 2021 · 0 comments
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Controls / Input Keyboard, mouse, keybindings, input UI, etc. <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc.

Comments

@Brambor
Copy link
Contributor

Brambor commented Aug 20, 2021

Is your feature request related to a problem? Please describe.

MENU_SCROLL isn't used in every menu. I encountered it missing in the crafting menu and didn't implement it in #50892 - player info display.

Describe the solution you'd like

Find where it is not used and use it there.

It would be amazing if some sort of simple function call would make the whole menu. I describe such function as

I have space there, and I have X items, figure out scrolling, ask me when you need to draw Xth line, I will provide text.

Describe alternatives you've considered

Don't waste time on improving the codebase (but a better codebase leads to less time wasted).

Additional context

Usually (from my super limited experience), everyone implements menu, scrollbar, highlighting ...

Also, there are different kinds of menus:
scrolling, split to pages, activate (lists things that can be activated and what does it do) has multiple columns (and uses class uilist from src/ui.h).

Also also: activate menu has more columns to prevent multiple pages, which are lost on resize - size down, but they're not added on resize - size up.

@actual-nh actual-nh added <Bug> This needs to be fixed <Enhancement / Feature> New features, or enhancements on existing [C++] Changes (can be) made in C++. Previously named `Code` Controls / Input Keyboard, mouse, keybindings, input UI, etc. Info / User Interface Game - player communication, menus, etc. Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Controls / Input Keyboard, mouse, keybindings, input UI, etc. <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

No branches or pull requests

2 participants