Use MENU_SCROLL in every relevant menu #50928
Labels
<Bug>
This needs to be fixed
[C++]
Changes (can be) made in C++. Previously named `Code`
Code: Infrastructure / Style / Static Analysis
Code internal infrastructure and style
Controls / Input
Keyboard, mouse, keybindings, input UI, etc.
<Enhancement / Feature>
New features, or enhancements on existing
Info / User Interface
Game - player communication, menus, etc.
Is your feature request related to a problem? Please describe.
MENU_SCROLL isn't used in every menu. I encountered it missing in the crafting menu and didn't implement it in #50892 - player info display.
Describe the solution you'd like
Find where it is not used and use it there.
It would be amazing if some sort of simple function call would make the whole menu. I describe such function as
Describe alternatives you've considered
Don't waste time on improving the codebase (but a better codebase leads to less time wasted).
Additional context
Usually (from my super limited experience), everyone implements menu, scrollbar, highlighting ...
Also, there are different kinds of menus:
scrolling, split to pages, activate (lists things that can be activated and what does it do) has multiple columns (and uses class uilist from src/ui.h).
Also also: activate menu has more columns to prevent multiple pages, which are lost on resize - size down, but they're not added on resize - size up.
The text was updated successfully, but these errors were encountered: