Info panel fixes and adding scrollbars

[Brambor]

Summary

None

Purpose of change

Fixes #50851,
While fixing this issue I found (and fixed) other issues:

• EFFECTS tab has priority over PROFICIENCIES tab.
• PROFICIENCIES tab has disgusting scrolling & is scrolling with others (while it's not selected).
• Tabs TRAITS, BIONICS, EFFECTS are missing scrollbar.
• Left side of the BIONICS tab doesn't have a border.
• Always start with space (| Abc instead of |Abc) - EFFECTS & PROFICIENCIES

Describe the solution

• Made similar code into functions. I might have overdone it in the case of static void draw_scrollbar.
• Merged features that were in some tabs, but not all. This fixed off by one error causing Proficiencies slidebar doesn't show up when 1 item is off the screen. #50851.
• Fix border off by 1 error.
• Some refactoring.

Describe alternatives you've considered

Since the scrollbar was only on one tab, remove it. But the scrollbar is useful, so I fixed it there and added it elsewhere.

Testing

Made save with lots of effects, bionic traits, mutations & proficiencies. Scrolling works, scrollbars too, everything is accounted for (nothing is under the screen as was in #50851). Resizing works.

Additional context

• There are more opportunities for merging two or more similar blocks of code into a function.
• c++17 would be nice.

Before:

After:

[Brambor]

My first c++ change in CDDA + first proper pull request.
So feedback is welecome. Did I overdo or underdo something?

[Qrox]

To fix the border bug, change the x position and width of the border at src/player_display.cpp:1407.

 ui_bionics.on_screen_resize( [&]( ui_adaptor & ui_bionics ) {
     bionics_win_size_y = calculate_trait_and_bionic_height().second;
     bionics_win_size_y = trait_and_bionic_height.second;
     w_bionics = catacurses::newwin( bionics_win_size_y, grid_width,
                                     point( grid_width + 1,
                                            infooffsetybottom + trait_win_size_y + 1 ) );
-    w_bionics_border = catacurses::newwin( bionics_win_size_y + 1, grid_width + 1,
-                                           point( grid_width + 1,
+    w_bionics_border = catacurses::newwin( bionics_win_size_y + 1, grid_width + 2,
+                                           point( grid_width,
                                                    infooffsetybottom + trait_win_size_y + 1 ) );
    border_bionics.set( point( grid_width, infooffsetybottom + trait_win_size_y ),
                        point( grid_width + 2, bionics_win_size_y + 2 ) );
    ui_bionics.position_from_window( w_bionics_border );
 } );

And I think a similar change should also be made for the traits tab, in case the traits tab is longer than the skills tab.

[chrispikula]

This is a really silly question, but is there any left-border bug on the third column? Of was that never an issue?

[Qrox]

The third column already draws the left border according to the code.

[Brambor]

Edit: fixed that the scrollbar on encumbrance wasn't displaying.

Is that all @Qrox ?

[Qrox]

Yeah, thanks for addressing the comments.