Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Football Armor is bulletproof to pistols #54909

Closed
Maleclypse opened this issue Jan 29, 2022 · 8 comments · Fixed by #55406
Closed

Football Armor is bulletproof to pistols #54909

Maleclypse opened this issue Jan 29, 2022 · 8 comments · Fixed by #55406
Labels
Good First Issue This is a good first issue for a new contributor Items / Item Actions / Item Qualities Items and how they work and interact (S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@Maleclypse
Copy link
Member

Describe the bug

21 Ballistic protection

Steps to reproduce

Spawn football armor
Look at stats
Marvel at the ballistic protection

Expected behavior

Not bullet proof.

Screenshots

image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 2009
  • Game Version: 761fb51 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions],
    Mythical Martial Arts [MMA],
    No Rail Stations [No_Rail_Stations],
    SpeedyDex [speedydex],
    Stats Through Kills [stats_through_kills],
    Stats Through Skills [StatsThroughSkills]
    ]

Additional context

No response

@Maleclypse Maleclypse added the Items / Item Actions / Item Qualities Items and how they work and interact label Jan 29, 2022
@Maleclypse
Copy link
Member Author

Western boots also seem to have 5 ballistic protection.

@Maleclypse Maleclypse added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jan 29, 2022
@Maleclypse
Copy link
Member Author

Arming Pants 5 Ballistic
Backpack 6 Ballistic

@Maleclypse Maleclypse added the Good First Issue This is a good first issue for a new contributor label Jan 30, 2022
@jackster483
Copy link
Contributor

Realistically, what should the ballistic value be for all of these?

@Maleclypse
Copy link
Member Author

Maleclypse commented Feb 1, 2022

probably half or so for all of them. Football armor could maybe sometimes get lucky and block .22 but nothing more than that.

@catdach
Copy link
Contributor

catdach commented Feb 7, 2022

Ok so ,an item's damage protection values are calculated as the protective value of its "material" multiplied by the item's "material_thickness". (I think if the item is made of multiple materials the material thickness is divided by the number of materials?)
The way I see it, there are 3 options for changing the bullet protection values of an item:

  1. Change the base bullet resist of the material (this will also effect every other item that use this material)
  2. Change the material thickness of the item (this will also effect the protection from every other type of damage)
  3. Change/add to/subtract from, the materials that the item is made of (see parentheses in option 2)

the football armor uses half "cotton" and half "thermoplastic resin"(which really just uses the proctection values of "Polymer resin") as materials, and it's material thickness is 6 (so (3*cotton proc)+(3*resin proc)). The bullet resist for resin is 6 which seems a little high to me as someone with no f-ing clue how bullet resistant plastic resin is. For reference, the bullet resist for cotton is 1, most metals, leather, and wood are 2, steel and "Synthetic Fabric" are 3, Kevlar is 5, and ballistic glass is 9.

@catdach
Copy link
Contributor

catdach commented Feb 7, 2022

Where was I going with that? oh yeah, you have to pick which option you want for each individual item. Cant just change the individual protection values of individual items.

TLDR: Its basically make the material itself less protective against bullets, or make the item less protective overall.

@jackster483
Copy link
Contributor

How did you figure out the formula for calculating the protection values? I assume it's not included in the JSON.

@catdach
Copy link
Contributor

catdach commented Feb 10, 2022

How did you figure out the formula for calculating the protection values? I assume it's not included in the JSON.

Mostly intuition and deduction from comparing the numbers in materials.json, the respective json files for specific items, and the actual in-game values. There is also a little bit of documentation I'm not sure how accurate the part about weighted averages is.(I'm not exactly sure that my formula for items with multiple materials is correct either, I would need to do a bit more extensive testing)

I certainly didn't go diving into the C++ or anything, though it might be a good idea if I want the real formula 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue This is a good first issue for a new contributor Items / Item Actions / Item Qualities Items and how they work and interact (S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants