[FINISHED!] [MOD] Craftable Weapons & Gunpowder

[Zaweri]

Adds a mod to add the old gunpowder recipe back due to popular demand. Also adds A LOT of craftable guns.

[chaosvolt]

Nice. If I may make a suggestion, one could also bump the recipe for blackpowder down to being autolearned, based on the idea of its access being balanced relative to smokeless powder. So basically if smokeless powder is uncraftable, then have blackpowder craftable via book, but if smokeless powder if craftable via book then make blackpowder autolearned.

[kevingranade]

It is not remotely reasonable for modern gunpowder to be craftable, see previous discussion elsewhere.

[chaosvolt]

As a mod content, maybe acceptable. As mainline, absolutely not and this is understandable.

If anything this could be the general go-to mod for nifty gunsmithing ideas that are too much of a breach in realism to allow for mainline. We'd need to massively expand on what all "veto'd for mainline" stuff should go here.

EDIT: Especially since just making gunpowder craftable is a bit odd of a thing to dedicate a whole PR'd mod to, so expanding on this would give it a purpose.

[drbig]

I concur with this being OK for a mod. It even comes with fair warning.

[kevingranade]

My bad, I missed that it was a mod from the summary since I'm on my phone. I'd much prefer that multiple things get bundled into the mod (eventually, this isn't a request for the PR), otherwise the mod selection menu gets terribly cluttered. Name suggestion, 'fast and loose gun mod'. :)

[chaosvolt]

Understandable, it doesn't say in the title that it's a mod.

And ja, more ideas for stuff to bundle in it. I dunno, Sten maybe? Once again drawing from my experience with content that shouldn't be craftable in mainline?

[drbig]

I'd much prefer that multiple things get bundled into the mod (eventually,
this isn't a request for the PR)

This one is pretty specific. As far as bundling goes: sure as long as it make sense, only caveat I have is that mixing JSON-only mods with Lua-requiring mods might be not so great.

[karlnp]

This would be a good candidate for other requested-but-suicidal gunsmithing ideas, like loading modern rounds with black powder, repriming rounds, etc.

[chaosvolt]

This would be a good candidate for other requested-but-suicidal gunsmithing ideas, like loading modern rounds with black powder, repriming rounds, etc.

Ja.

[Zaweri]

There we go, testing worked as intended and everything worked flawlessly. Damn I'm good.

[chaosvolt]

pipe SMG: 9mm

So instead of a Sten, which is easily made with basic metalworking knowledge and tool in reality, you add a generic version.

EDIT: You also basically re-used said recipes for the single-shot pipe guns for makeshift SMGs. At least I went through the trouble of reading that manual some guy linked me to and tried to emulate it in recipe form.

EDIT 2. Here we go, see a comment in #12481 from Chezzo.

Wasn't the Sten gun a horrible weapon that jammed all the time?

Anyways, you can craft it, according to Practical Scrap Metal Arms Vol. 3:

http://www.mediafire.com/view/5v4852yage8d8c5

[Zaweri]

Chaosvolt, I am adding stuff that existed in the game before, and variations of it. I don't want to make new stuff. I just want the old guns back. And I want to keep at least a some sort of balance, the Sten is a pretty damn good smg in the game.

[chaosvolt]

...we had pipe SMGs in the past? How long ago was this?

[Zaweri]

Old man voice Back in my day, Pipe SMG's existed... They were in 0.5, when I started playing... Don't know where they went.

[chaosvolt]

They must've went the way of sanity and logic, because whoever added them half-assed it big time, if you're using the original recipes. Seeing as they seem to just use pipe rifle recipes with some minor edits...

If this is basically just re-implementing content removed due to breaches of realism, then I suppose it's understandable.

EDIT: While we're on the subject of re-adding removed content, what about snare triggers and snare kits? Is there anything making them fundamentally BROKEN, or were they just too underwhelming to exist?

EDIT 2: Ahah. Relevant PRs were #8054 and #10328 it seems. And...sweet zombie Jesus, it isn't your fault. The original recipes really WERE that half-assed.

[kevingranade]

Just to be clear, mod authorship doesn't mean "owning" the code, if @chaosvolt wants to make some of the recipes more reasonable, that should be fine, yes?

[chaosvolt]

If one does implement a more realistic recipe for a handcrafted SMG...hmm. Where'd I leave that example recipe I was going to propose way back when...

Would've been closer to the "practical scrap metal arms" recipe than the recipe I first proposed even farther back when I added the Sten. I'm assuming I scrapped it once it was clarified that the survivor .223 and .308 rifles are only described as semi-auto due to the game derping.