Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upDrop charge rifle #15713
Conversation
mugling
added some commits
Mar 9, 2016
mugling
force-pushed the
mugling:chrif
branch
to
564f131
Mar 11, 2016
Rivet-the-Zombie
added a commit
that referenced
this pull request
Mar 14, 2016
Rivet-the-Zombie
merged commit 817c6b6
into
CleverRaven:master
Mar 14, 2016
1 check passed
default
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mugling commentedMar 9, 2016
Follows the discussion in #15701.
The implementation is hideous as evidenced by the quantity and quality of code removed in 370dd71 and as @Coolthulhu succinctly pointed out:
I've looked into @BevapDin's suggestion of moving some of the functionality within
item::ammo_databut as the charger gun actually works by continually resetting the properties of a magicalitypethis wouldn't be a much cleaner solution and in any case doesn't deal with the innumerable other special cases throughout the code base.I'm of the opinion that there's no realistic hope of salvaging it without a complete re-implementation and that this wouldn't be worth the effort considering the minimal use.
93e4129 and 526924c stop the player wieldable version spawning and 370dd71 converts any turrets to the laser rifle