Drop charge rifle #15713
Merged
Drop charge rifle #15713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the discussion in #15701.
The implementation is hideous as evidenced by the quantity and quality of code removed in 370dd71 and as @Coolthulhu succinctly pointed out:
I've looked into @BevapDin's suggestion of moving some of the functionality within
item::ammo_databut as the charger gun actually works by continually resetting the properties of a magicalitypethis wouldn't be a much cleaner solution and in any case doesn't deal with the innumerable other special cases throughout the code base.I'm of the opinion that there's no realistic hope of salvaging it without a complete re-implementation and that this wouldn't be worth the effort considering the minimal use.
93e4129 and 526924c stop the player wieldable version spawning and 370dd71 converts any turrets to the laser rifle