Improve comestible menu performance

[ralreegorganon]

Summary

SUMMARY: Bugfixes "Improve comestible menu performance."

Purpose of change

The lambdas for determining calories and joy for the player in the comestible menu were capturing a copy of the player. With the current map memory bugs, this meant a potentially very large object was being copied several times, every time the comestible menu was displayed, leading to a large delay.

Describe the solution

Changed the lambdas to capture the player object by reference.

Additional context

Fixing the map memory will also help resolve this, but this will mitigate the issue in the meantime.

[kevingranade]

Just double checked, player::fun_for() and player::nutrition_for() are const.

[jbytheway]

Does it ever make sense to copy a player object? Should it be made non-copyable to catch these sorts of issues?

[kevingranade]

It should at least be made not implicitly copyable. I believe there are some situations where that's the only way to accomplish something. Even for those though, we could likely instead implement a much cheaper shallow copy that doesnt copy any large data members.