Fix for multipart doors. #26546
Merged
Fix for multipart doors. #26546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous change got parts[next_index] and parts[part_index] confused, this corrects that.
ZhilkinSerg
reviewed
Nov 5, 2018
ZhilkinSerg
added
Vehicles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous change got parts[next_index] and parts[part_index] confused, this corrects that.
Summary
SUMMARY: NonePurpose of change
This corrects a logic error introduced by #26477
The expected symptom is that opening or closing multitile doors will fail to propagate to adjacent door pieces.
Describe the solution
Extract the part coordinate for comparison purposes instead of accidentally subtracting it from itself.
Describe alternatives you've considered
The whole function needs cleaning up, but I don't have time for that at the moment.