NPC hearing #27152
Merged
NPC hearing #27152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlangsdorf
force-pushed
the
npc_hearing
branch
from
2ca370f
to
812afd6
Compare
mlangsdorf
added
<Enhancement / Feature>
mlangsdorf
force-pushed
the
npc_hearing
branch
from
812afd6
to
c533a1a
Compare
Force all sounds to have descriptions and categories, and then tighten up the conditions for printing out a description of the sound.
call process_sound_markers() on all NPCs within MAP_VIEW_DISTANCE of the player, and have them call a new npc::handle_sound() function for each sound marker, and then bail before actually placing the sound markers which remains a player only function. npc::handle_sound() ignores speech (for not) and sounds from locations that the NPC can see. If the NPC currently has a low assessment of danger and hears combat noises or movement, they will complain to the player.
mlangsdorf
force-pushed
the
npc_hearing
branch
from
c533a1a
to
fe3a4bd
Compare
|
More to do, but this is a good start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "NPC hearing"Purpose of change
Addresses #22710, #22711
Give NPCs the ability to hear stuff, and eventually respond to things that they heard.
Describe the solution
call process_sound_markers() on all NPCs within MAP_VIEW_DISTANCE of the player, and have them call a new npc::handle_sound() function for each sound marker, and then bail before actually placing the sound markers which remains a player only function.
in npc::handle_sound(), the NPC checks to see if their total danger assessment (from npcmove.cpp) is below 1. If it is and they hear footsteps or combat noises but they can't see the source, they will complain/warn the player.
Describe alternatives you've considered
NPCs hear sounds before activity is processed. It might make more sense for activity to be processed and then have NPCs hear the resulting sounds.
This probably needs integration into npcmove.cpp.