Seed mapgen in tests for reproducibility #27416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
Code: Tests
Previously we were seeding the RNG before each test, but not before mapgen, so some failures were not reproducible.
peperov
pushed a commit
to peperov/Cataclysm-DDA
that referenced
this pull request
Jan 12, 2019
Previously we were seeding the RNG before each test, but not before mapgen, so some failures were not reproducible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Better test reproducibility (yet again)"
Purpose of change
We are seeding the RNG before each test, but not before mapgen, so some failures were not reproducible.
Describe the solution
Seed at the start also.
Additional context
If and when #27062 is merged the
srandcall here should become redundant, and the whole thing can be simplified to justrng_set_engine_seed( session.config().rngSeed() );