Fix 27487: Ensure vehicle loot zone has corresponding cargo part on refresh #28142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to be and safety out if its not there
|
Merged to 0.D and master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Ensure vehicle loot zone has corresponding cargo part on refresh"
Purpose of change
Fixes #27487
Describe the solution
When refreshing loot zone absolute positions on a vehicle, if the loot_zone expects to be mounted to a position where there will be a cargo part and there is no cargo part, we end up with a crash. Instead, we will now print a debug message alerting the player to the issue and remove the loot zone.
The road to reproing the conditions under which the loot_zones on the vehicle got out of sync from the parts on the vehicle is almost impossible to reproduce in a meaningful timeframe so I will not attempt to chase down how the logic around removing parts that have loot zones on them did not remove the loot_zone when the cargo part was removed.