Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npctalk: set the duration of permanent effects to 1000 days #28220

Closed
wants to merge 1 commit into from

Conversation

mlangsdorf
Copy link
Contributor

@mlangsdorf mlangsdorf commented Feb 16, 2019

Summary

SUMMARY: Bugfixes "npctalk: set the duration of permanent effects to 1000 days"

Purpose of change

Fixes #28129
set the duration of permanent effects to 1000 days, in addition to being permanent. This should fix the issue where they were expiring immediately after closing the NPC dialogue.

set the duration of permanent effects to 1000 days, in addition to
being permanent.  This should fix the issue where they were expiring
immediately after closing the NPC dialogue.
@mlangsdorf mlangsdorf added NPC / Factions NPCs, AI, Speech, Factions, Ownership [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) labels Feb 16, 2019
@kevingranade
Copy link
Member

Merged to 0.D and master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding permanent effects via npctalk no longer functional
2 participants