Try union workaround to function cast warning #30803
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
The pragma-based solution wasn't working on older gcc versions. It could be made to work with extra
#ifdef
s, but would be even more messy.Describe the solution
Try a solution using unions to type-pun instead.
Describe alternatives you've considered
We've tried various ways of casting, but they all tend to fall foul of a different compiler warning.
Additional context
I can't compile this locally, so relying on CI to do so.