Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

item ownership fixes #30814

Merged
merged 1 commit into from May 24, 2019
Merged

item ownership fixes #30814

merged 1 commit into from May 24, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 24, 2019

Summary

SUMMARY: Bugfixes "Adds ownership to NPC gifts and newly crafted items"

Purpose of change

Shortly after #29834 was merged, some problems emerged.
When NPCs gave you a gift, they immediately demanded it back and called you a thief, hilarity aside, thats now been fixed.
Also newly crafted items, are assigned ownership to player faction

Describe the solution

As above

Describe alternatives you've considered

N/A

Additional context

Currently, the mapgen ownership zones means that only newly generated refugee centers will show as owned, and existing generated refugee centers wont be protected from player theft. This is not considered a priority to fix.

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` NPC / Factions NPCs, AI, Speech, Factions, Ownership labels May 24, 2019
@ZhilkinSerg ZhilkinSerg self-assigned this May 24, 2019
@ZhilkinSerg ZhilkinSerg merged commit e5f16b9 into CleverRaven:master May 24, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment May 24, 2019
@ghost ghost deleted the ownership_fixes branch September 11, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant