Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip do not merge] encapsulate character mutation data into a new class, character_mutations #34807

Closed
wants to merge 34 commits into from

Conversation

KorGgenT
Copy link
Member

Summary

SUMMARY: Infrastructure "Encapsulate character_mutations"

Purpose of change

This is a big step toward #34721 and additionally a larger goal of further encapsulation. This will point more toward putting mutation related functions into this class, rather than extending the Character class indefinitely, leading to a very large class.

Describe the solution

Moves the various mutation based members into a class called character_mutations. This class will keep track of the actual mutations the character has, and has the functions that interface with these private members.

  • move members into new class
  • change function definitions to proper location
  • write loading migration code

Describe alternatives you've considered

Just doing as the attached issue says and moving all the members over to Character. I decided that I might as well get it over with =P

Testing

in progress

Additional context

Opening this up as a draft now in order to be transparent, and it's also the easiest way i know of to be able to see a diff of code changes, just in case I change something i didn't really want to via rebasing against upstream.

@KorGgenT KorGgenT added Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Oct 16, 2019
@KorGgenT KorGgenT changed the title encapsulate character mutation data into a new class, character_mutations [wip do not merge] encapsulate character mutation data into a new class, character_mutations Oct 16, 2019
@KorGgenT
Copy link
Member Author

woops, i must have hit a wrong button. this was supposed to be a draft. oh well.

@KorGgenT
Copy link
Member Author

i'm going to close this because there are a lot more prereqs for this PR than i thought. i'll come back to it later.

@KorGgenT KorGgenT closed this Oct 20, 2019
@KorGgenT KorGgenT deleted the character_mutations branch January 8, 2020 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant