-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip do not merge] encapsulate character mutation data into a new class, character_mutations #34807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woops, i must have hit a wrong button. this was supposed to be a draft. oh well. |
9cdc8fd
to
021a8cf
Compare
3d11974
to
8174887
Compare
i'm going to close this because there are a lot more prereqs for this PR than i thought. i'll come back to it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[C++]
Changes (can be) made in C++. Previously named `Code`
Code: Infrastructure / Style / Static Analysis
Code internal infrastructure and style
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Encapsulate character_mutations"
Purpose of change
This is a big step toward #34721 and additionally a larger goal of further encapsulation. This will point more toward putting mutation related functions into this class, rather than extending the Character class indefinitely, leading to a very large class.
Describe the solution
Moves the various mutation based members into a class called character_mutations. This class will keep track of the actual mutations the character has, and has the functions that interface with these private members.
Describe alternatives you've considered
Just doing as the attached issue says and moving all the members over to Character. I decided that I might as well get it over with =P
Testing
in progress
Additional context
Opening this up as a draft now in order to be transparent, and it's also the easiest way i know of to be able to see a diff of code changes, just in case I change something i didn't really want to via rebasing against upstream.