Megastore Save Compatibility #34952
Merged
Megastore Save Compatibility #34952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extra space for vertical alignment isn't "Astyle"
|
The failed test is about body part hit probability, which this PR in no way touches. |
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixes loading worlds with old megastores"Purpose of change
Fixes #34860 - Added save migration code for old megastore specials which was missing from #34625.
Updated alt map keys to reflect the new ids.Describe the solution
Because megastores are 3x3 with some strange OM symmetry but not tile specific symmetry, each cardinal orientation needed to be tested for before the appropriate replacement code could be executed.
Describe alternatives you've considered
Leave old saves broken.
Adjust the "nearby" conversion code to allow for more complex adjacency checks
Testing
Loaded one of my old worlds and teleported to three different megastores. Each loaded with the correct orientation without any problems.