Mainline/jsonify megastore

[chaisawlajatang]

Summary

SUMMARY: Content "Mainline jsonified megastore from the Mapgen Demo mod"

Purpose of change

The old megastore is boring and obsolete.

Describe the solution

But the Mapgen Demo offers a really nice solution.

Describe alternatives you've considered

Leave everything as is.

Additional context

I tweaked the building a bit and squeezed it into one file. Removed the old megastore from the hardcode completely.

[Night-Pryanik]

I'd prefer having both variants in game.

[anothersimulacrum]

I'd suggest you use https://github.com/CleverRaven/Cataclysm-DDA/blob/master/tools/merge_maps.py
On this map, there's no need for each OMT to be defined individually.

[chaisawlajatang]

I'd prefer having both variants in game.

An old one looks like an empty hangar with rows of metal shelves.

I'd suggest you use

I doubt it will help. @SunshineDistillery (author of the mod) made the building (and FEMA camp, and missile silo) in a strange (for me) way and introduced lots of 24x24 variations of each overmap tile and rotated them as needed.

[chaisawlajatang]

Hmmm, that's strange, it says megastore.json has to be linted, but I already linted it via http://dev.narc.ro/cataclysm/format.html

[anothersimulacrum]

https://github.com/CleverRaven/Cataclysm-DDA/pull/34625/checks?check_run_id=255493810#step:4:13

[ZhilkinSerg]

I'd prefer having both variants in game.

I agree, but in json form instead of hardcode C++ mapgen functrion.

[chaisawlajatang]

I agree, but in json form instead of hardcode C++ mapgen functrion.

It would be heavily modified anyway, because new building has 2 stories+roof and parking lots. And just compare them, I believe megastore made by @SunshineDistillery is much better.

Before

After

[JonnieCache]

this breaks my savegame with a crash in a deserialize function in savegame.cpp (iirc, ive rolled back now), is this expected behaviour?

I guess its because the old megastore definition is removed?

Sorry if this is intended, I looked to see if the project has a policy about breaking savegames or not but I couldnt see one

[ZhilkinSerg]

this breaks my savegame with a crash in a deserialize function in savegame.cpp (iirc, ive rolled back now), is this expected behaviour?

Provide a savegame.

[JonnieCache]

Abell.zip

running windows 7, x64 build

bring up the map, go up the the surface Z level and then pan westwards until the large city is in view, this triggers the crash for me

[ZhilkinSerg]

Savegame migration code is missing - it needs to be something like in #33339.

I've started it in 5995ba3, but it is not migrating all tiles properly (some numbers need to be updated in savegame.cpp).