Rework door/safe hacking to be mostly in activity_handlers #35717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Rework door/safe hacking to be mostly in activity_handlers"
Purpose of change
Fixes #35707
Fixes #35602
Fixes #35195
Describe the solution
So the activity to hack a door or a safe, also called iexamine::hack_attempt() which subtracted moves manually, in addition to the activity.
I couldnt just remove that, because other things used hack_attempt() too, like hacking the gas station console.
So the best way was to consolidate it all in the activity code, and add differing results based on what the hack type is, also I added a prompt before the activity starts, because currently it just starts the activity when you examine the cardreader/safe automatically.
Describe alternatives you've considered
N/A
Testing
Loaded the save in th elinked issue, examined the cardreader, said yes to prompt, activity started, used electrohack, door opened, repeated test on electric gun safe and gas station console.
All works as before, except without the extra minutes of manual moves subtracted after the activity.
And now more extensible.
Additional context
N/A