Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for incompatible magazine spawning in national guard camp #35794

Merged
merged 2 commits into from
Dec 1, 2019
Merged

Conversation

hfox
Copy link
Contributor

@hfox hfox commented Nov 30, 2019

Summary

SUMMARY: Bugfixes "Correct magazine inside guns/monsters."

Purpose of change

I found a SCAR-L in the national guard camp, but when picking it up, the game crashed with weird messages. After examining the logs and savegame, I concluded that it contained the wrong magazine(scarhmag).
I also got errors about the W12B10 using incompatible magazines for their flamethrowers, roughly same conclusion.

Describe the solution

Setting the SCAR-L in the national guard itemgroup to spawn/drop with the correct magazine.
Setting the W12B10 to use napalm insted of gasoline for their flamethrower.

Describe alternatives you've considered

  • Changing the gun to a SCAR-H and ammo drops to 7.62x51mm, would make some sense due to monster descriptions.
  • Making the monsters drop their actual gun instead, but I need some guidance on how for that option.

Testing

edited, killed a few W11B10(dropping that itemgroup), and the SCAR-Ls did not crash the game.
edited, spawned a few W12B10, they burned me a lot.

Additional context

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) Items / Item Actions / Item Qualities Items and how they work and interact Items: Magazines Ammo holding items and objects. Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Monsters Monsters both friendly and unfriendly. [JSON] Changes (can be) made in JSON labels Dec 1, 2019
@ZhilkinSerg ZhilkinSerg merged commit 54572ca into CleverRaven:master Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items / Item Actions / Item Qualities Items and how they work and interact Items: Magazines Ammo holding items and objects. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants