Jsonized field description affixes #35839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[JSON]
ZhilkinSerg
force-pushed
the
jsonize-field-description-affix
branch
2 times, most recently
from
8a4cd9b
to
568e13b
Compare
ZhilkinSerg
commented
Dec 5, 2019
ZhilkinSerg
force-pushed
the
jsonize-field-description-affix
branch
from
41961df
to
305b103
Compare
ZhilkinSerg
commented
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Jsonized field description affixes'"Purpose of change
Allow definition of description affixes for new field types via json.
Describe the solution
Load field type description affixes from field type json.
Testing
Make some selfies with pro-camera in-game standing in and near various fields and check field descriptions afterwards.