Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aftershock] Modify flatbread recipe #35875

Merged
merged 1 commit into from
Dec 6, 2019
Merged

[Aftershock] Modify flatbread recipe #35875

merged 1 commit into from
Dec 6, 2019

Conversation

arijust
Copy link
Contributor

@arijust arijust commented Dec 5, 2019

Summary

SUMMARY: Mods "Modify flatbread recipe in Aftershock"

Purpose of change

Close #35800

Describe the solution

Change amount of charges to 2.
It makes crafted flatbread have the same amount of calories as normal one.
Except for one extra portion for crafted one.

@Fris0uman
Copy link
Contributor

Why does aftershock have a recipe for bread and flatbread in it? What's scify about bread?

@arijust
Copy link
Contributor Author

arijust commented Dec 5, 2019

Why does aftershock have a recipe for bread and flatbread in it?

I don't know. It isn't bad idea to mainline that, I guess.

What's sci-fi about bread?

Means of its production for paleolithic age?

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks Mods Issues related to mods or modding labels Dec 5, 2019
@Maleclypse
Copy link
Member

Maleclypse commented Dec 5, 2019

Dough and rolling pin could also be mainlined from Aftershock.

@Davi-DeGanne
Copy link
Contributor

I don't understand what dough adds to the game. There is no reason for a differentiation of two separate processes (from dough and from flour) for bread-making, as such a differentiation doesn't exist in real life. So if we added bread from dough into mainline, it would have to replace bread from flour since bread from flour implicitly includes dough as an intermediate product.

I don't see what that replacement adds, besides more unnecessary fiddling with the UI; why would someone ever want to craft dough, but not craft anything from said dough?

@Maleclypse
Copy link
Member

Maleclypse commented Dec 5, 2019

I don't understand what dough adds to the game. There is no reason for a differentiation of two separate processes (from dough and from flour) for bread-making, as such a differentiation doesn't exist in real life. So if we added bread from dough into mainline, it would have to replace bread from flour since bread from flour implicitly includes dough as an intermediate product.

I don't see what that replacement adds, besides more unnecessary fiddling with the UI; why would someone ever want to craft dough, but not craft anything from said dough?

I'm more stating that I'd like to see things that can be mainlined, out of Aftershock. I'm not pro dough or anti dough. But I definitely would prefer flatbread be mainlined rather than in Aftershock.

Edit: For items that can't or shouldn't be mainlined from Aftershock and don't fit the theme, I will plan on looking through them and seeing if they need to be removed or repaired. I'm sure there will be items that don't fit the theme that I leave in but I'd like to keep it in a general direction.

@Davi-DeGanne
Copy link
Contributor

I definitely would prefer flatbread be mainlined rather than in Aftershock

Flatbread is not in Aftershock, it's part of the base game. The only thing regarding flatbread that Aftershock adds is an additional recipe for flatbread that uses dough instead of flour, so dough is central to this discussion.

I totally agree that Aftershock should have a defined direction and not be adding weird food recipes. But I also don't think the dough recipes fit in the base game. And simultaneously, I don't really use/maintain Aftershock personally, so I don't really feel qualified to say we should remove dough and all related recipes from it.

@Maleclypse
Copy link
Member

I totally agree that Aftershock should have a defined direction and not be adding weird food recipes. But I also don't think the dough recipes fit in the base game. And simultaneously, I don't really use/maintain Aftershock personally, so I don't really feel qualified to say we should remove dough and all related recipes from it.

I'll try and examine dough in Aftershock more closely this winter, since I've currently volunteered to maintain it. I haven't spent enough time with Aftershock yet to really feel good about making decisions to remove things the mod creator put in completely.
@arijust thank you for putting this fix together.

@arijust
Copy link
Contributor Author

arijust commented Dec 5, 2019

thank you for putting this fix together

You're welcome.

@ZhilkinSerg ZhilkinSerg merged commit ad738ea into CleverRaven:master Dec 6, 2019
@arijust arijust deleted the flatbread_fix branch December 6, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flatbread has 9x more calories than player crafted flatbread.
5 participants