add sound/deafness to labels and labels-narrow sidebar layouts #35886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esotericist
added
[C++]
I-am-Erk
pushed a commit
to I-am-Erk/Cataclysm-DDA
that referenced
this pull request
Dec 6, 2019
…rRaven#35886) * add sound/deafness to labels and labels-narrow sidebar layouts * attempt to appease clang-tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY: Interface "add sound/deafness to labels and labels-narrow sidebar layouts"Purpose of change
it turns out that there is no indicator for player-generated-sound or player-deafness in the labels or labels-narrow sidebar layouts, which deprives users of sometimes-critical-information
Describe the solution
added sound/deafness indicator to the
draw_needs_labelspanel of the labels layoutadded a new
draw_sound_narrowpanel to the labels-narrow layoutDescribe alternatives you've considered
this originally came up in the context of a player wanting a warning when setting alarm when they had earplugs in
it's possible the primary use cases where this would matter could be addressed when relevant, but since there was empty room in the labels layout and you can disable the new panel for labels-narrow, it seemed sensible to just go ahead and add this information
Testing
loaded game, equipped earplugs, also ran around and smashed things w/out earplugs, verifying noise showed up as expected
Additional context
labels narrow sound
labels narrow deaf
labels deaf
