Added hints for New Game modes #35927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Night-Pryanik
added
<Enhancement / Feature>
cainiaowu
reviewed
Dec 7, 2019
src/main_menu.cpp
Outdated
| @@ -702,6 +702,13 @@ bool main_menu::new_character_tab() | |||
| vSubItems.push_back( pgettext( "Main Menu|New Game", "Play Now! (<F|f>ixed Scenario)" ) ); | |||
| vSubItems.push_back( pgettext( "Main Menu|New Game", "Play <N|n>ow!" ) ); | |||
| } | |||
| std::vector<std::string> hints; | |||
| hints.push_back( "Allows you to fully customize points pool, scenario, and character's profession, stats, traits, skills and other parameters." ); | |||
There was a problem hiding this comment.
Translation happens below, on line 722.
There was a problem hiding this comment.
These strings are not marked for translation. And _() will do nothing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Added hints for New Game modes."Purpose of change
Reduce confusion for newer players when they select New Game.
Describe the solution
Created set of hints. Show it when selecting New Game.
Describe alternatives you've considered
Based on discussion in this Reddit post, rename both "Play Now!" modes to something more clear.
Testing
Launched game, selected New Game, scrolled through all game modes.
Additional context
Hints' text and/or color could be changed if needed.