Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dangerzone map notes #36983

Merged
merged 2 commits into from Jan 13, 2020
Merged

Dangerzone map notes #36983

merged 2 commits into from Jan 13, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 12, 2020

Summary

SUMMARY: Features "Dangerzone map notes"

Purpose of change

Fixes #36792

Describe the solution

Allow you to mark a map note as dangerous from the list notes UI, and set a danger radius.

Pathing will then reject this area nad go around it.

Describe alternatives you've considered

Other ways of marking it, perhaps by choosing a specific color or symbol, but rejected that as too ambigious, better if its set specifically as a bool.

Testing

Made a map note, in the list notes UI, I marked it as dangerous from the new UI key option displayed there, this then displayed the Dangerous area! top-right map text when hovering over the note, and when selecting an autotravel route, it went around that point.
Tried again with a radius of 2, and it went around that expanded area.

When trying to select a point to path to within a danger area, the game hangs briefly, this is trying all possible routes to get within the danger zone, but cannot, I dont see this as a huge problem, its a bit annoying but im not sure how to fix that.

Additional context

N/A

src/overmap_ui.cpp Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Jan 12, 2020

Forgot to mention - made a little change to the pathing code while I was there, where it prompts if you want to swim along the path.

This was annoying, when its entirely situational, if you are in water already, or the path end point is in water, its obvious you wan tto swim, so I tested for those conditions instead.
Its a bit unrelated to this PR, but I was in that code area already.

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Map / Mapgen Overmap, Mapgen, Map extras, Map display [JSON] Changes (can be) made in JSON labels Jan 13, 2020
@ZhilkinSerg ZhilkinSerg merged commit 3b80958 into CleverRaven:master Jan 13, 2020
@ghost ghost deleted the map_note_hazardous branch January 17, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let me mark obstacles for the overmap auto walk feature
2 participants