jsonize spell skills #37368
Merged
jsonize spell skills #37368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
<Enhancement / Feature>
This was referenced Jan 26, 2020
|
i apparently forgot to link the feature request, here: #36937 |
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 15, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 15, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 16, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 17, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 17, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 18, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 29, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 1, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 1, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 2, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "jsonize skill used for spells"Purpose of change
more data-driven code
Describe the solution
adds a new member to spell_type that is a skill_id. defaults to spellcraft because vanilla doesn't really use spells besides artifact spells, which won't have failure chances in the same way
Testing
loaded in vanilla without magiclysm to check that the default skill "spellcraft" does not cause errors when casting artifact active spells that exist in vanilla already. changed a skill to driving to see the failure chance adjust properly