Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aftershock] Mastodon Mutation Line and Uplifted SWAT Profession #37660

Merged
merged 45 commits into from Apr 14, 2020

Conversation

Maleclypse
Copy link
Member

@Maleclypse Maleclypse commented Feb 3, 2020

Summary

SUMMARY: Mods "Mutation Line and profession"

Purpose of change

Adding uplifted animal species to Aftershock. May add Mastadon mutagen later.

Describe the solution

Adds a mutation line with placeholders for two mutations that need to be jsonized and notes items that need to wait on Mutant NPCs merging.

Describe alternatives you've considered

None. In fact this will mean needing to add additional zombie types for some uplifted species.

Testing

TBD

Additional context

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Mods: Aftershock Anything to do with the Aftershock mod Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies 0.E Content Freeze labels Feb 3, 2020
data/mods/Aftershock/items/xl_gear.json Outdated Show resolved Hide resolved
data/mods/Aftershock/player/professions.json Outdated Show resolved Hide resolved
data/mods/Aftershock/player/professions.json Outdated Show resolved Hide resolved
data/mods/Aftershock/player/professions.json Outdated Show resolved Hide resolved
{ "level": 1, "name": "melee" },
{ "level": 1, "name": "bashing" }
],
"traits": [ "PROF_SWAT", "THRESH_MASTODON" ],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are still missing the other mutations here, I think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on Mutant NPCs to merge so I can try and make the profession load with random mutations.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah got it.

@John-Candlebury
Copy link
Member

Seems good baring the thematic clash in the mutation descriptions.
I'm also not very familiar with the whole mutation system, but I think you are still missing several cancels.

@Maleclypse
Copy link
Member Author

Maleclypse commented Feb 11, 2020

Note to self: Uplifted Mutagens will require the new advanced crafting materials.

edit: completed

Maleclypse and others added 15 commits March 26, 2020 22:57
Needs some jsonizing of two mutations. Needs items as well.
Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>
Co-Authored-By: LaVeyanFiend <51099123+LaVeyanFiend@users.noreply.github.com>
Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>
Co-Authored-By: John Candlebury <johncandlebury@gmail.com>
Co-Authored-By: John Candlebury <johncandlebury@gmail.com>
Co-Authored-By: John Candlebury <johncandlebury@gmail.com>
Co-Authored-By: John Candlebury <johncandlebury@gmail.com>
@Maleclypse
Copy link
Member Author

@KorGgenT no stress on when you can look at this but I cannot get this to recognize extends in mutations following the format in the documentation. A few CI tests back is the way we talked about on Discord.

@KorGgenT
Copy link
Member

KorGgenT commented Apr 5, 2020

You need to use copy-from in order to use extend. like so:

  {
    "type": "mutation",
    "id": "RUMINANT",
    "copy-from": "RUMINANT",
    "extend": { "category": [ "MASTODON" ] }
  },

and make sure you're only putting down the fields that actually change in the mutation, this was deleting lots of the things you had there that should be unecessary.

@Maleclypse
Copy link
Member Author

I'm pretty sure the answer to this is no, but is there currently any way to give a trait group of mutations to a profession that get randomly selected? I thought I had mirrored what I needed to similar to the demographic traits but I'm pulling an error from the trait group not existing for that profession?

@Maleclypse Maleclypse changed the title WIP [Aftershock] Mastodon Mutation Line and Uplifted SWAT Profession [Aftershock] Mastodon Mutation Line and Uplifted SWAT Profession Apr 13, 2020
@Maleclypse Maleclypse changed the title [Aftershock] Mastodon Mutation Line and Uplifted SWAT Profession WIP [Aftershock] Mastodon Mutation Line and Uplifted SWAT Profession Apr 13, 2020
@Maleclypse Maleclypse changed the title WIP [Aftershock] Mastodon Mutation Line and Uplifted SWAT Profession [Aftershock] Mastodon Mutation Line and Uplifted SWAT Profession Apr 14, 2020
@ZhilkinSerg ZhilkinSerg merged commit 62e99a7 into CleverRaven:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mods: Aftershock Anything to do with the Aftershock mod Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants