Make the baseball diamond square and centered #38755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No items or monsters; won't load for some reason, but using as a starting point for next edits (which will be a lot easier with the whole map in one place).
|
Looks much better! |
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Make the baseball diamond square and centered"Purpose of change
Fixes #38753
Describe the solution
Describe alternatives you've considered
Considered re-orienting the diamond to follow x/y paths instead of diagonals (since I think that would look better in most tilesets), and also considered embellishing the field with foul lines, spectator stands, and some more interesting terrain - but I would prefer to leave that to someone who actually cares about baseball.
Testing
Spawned some baseball fields with the debug menu and verified that it looks OK, and has expected items and monsters.
Additional context
Thanks @curstwist for the help on this one