Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc clang-tidy fixes #39367

Merged
merged 1 commit into from Apr 8, 2020
Merged

Misc clang-tidy fixes #39367

merged 1 commit into from Apr 8, 2020

Conversation

jbytheway
Copy link
Contributor

Summary

SUMMARY: None

Purpose of change

Appease clang-tidy.

Describe the solution

A few minor fixes:

  • Move a translator comment.
  • Suppress a named constant suggestion.
  • Suppress a null pointer concern.

Testing

Build only.

Additional context

Discovered while fixing issues on #39351.

@jbytheway jbytheway mentioned this pull request Apr 8, 2020
Merged
@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Code: Build Issues regarding different builds and build environments labels Apr 8, 2020
@ZhilkinSerg ZhilkinSerg merged commit 8396b7c into CleverRaven:master Apr 8, 2020
@jbytheway jbytheway deleted the clang_tidy_20200408 branch April 9, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Build Issues regarding different builds and build environments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbytheway @ZhilkinSerg