Fix a crash in item::use_amount #39566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlangsdorf
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix a crash when some action consumes inventory items"
Purpose of change
Fixes #39507 and fixes #39509. Calling
remove_itemin the lambda function initem_use_amountcaused memory corruption that caused the game to crash when the next contained item is visited.Describe the solution
Populate a list of removed items and remove them after visiting all contained items.
Testing
Loaded @Damdern's save from #39507 and the save from #39509, and the crash no longer happened.
Additional context
May also fix #39522 since the crash log looks similar to @Damdern's crash log in #39507.