Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate code #39768

Merged
merged 3 commits into from
Apr 21, 2020
Merged

Migrate code #39768

merged 3 commits into from
Apr 21, 2020

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented Apr 20, 2020

Summary

SUMMARY: Infrastructure "Migrate more functions from player to character"

Purpose of change

Part of #34721
Moving code from player to character

Describe the solution

Describe alternatives you've considered

Testing

Additional context

@ralreegorganon
Copy link
Contributor

known_traps has a save/load in player that should be pushed down into character too, as you did with the automove route.

@lgtm-com
Copy link

lgtm-com bot commented Apr 21, 2020

This pull request introduces 1 alert when merging 3992fb3 into b8163fd - view on LGTM.com

new alerts:

  • 1 for Local variable hides global variable

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Character / Player Character / Player mechanics labels Apr 21, 2020
@ZhilkinSerg ZhilkinSerg merged commit 43d8b78 into CleverRaven:master Apr 21, 2020
@Ramza13 Ramza13 deleted the player_migrate branch April 21, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Character / Player Character / Player mechanics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ramza13 @ralreegorganon @ZhilkinSerg