Move a ton of code from player to character #39832
Conversation
| int climbing_cost( const tripoint &from, const tripoint &to ) const; | ||
| void environmental_revert_effect(); | ||
| /** This handles giving xp for a skill */ | ||
| void practice( const skill_id &id, int amount, int cap = 99, bool suppress_warning = false ); |
There was a problem hiding this comment.
Could I ask you to hold off on this until #39387 is either merged or closed, to prevent merge conflicts? No big deal if you don't just thought I should ask.
There was a problem hiding this comment.
Hmmm so I'm scared of letting this sit around because changes made to any of the functions I moved here will be hard to spot since they are copy pasted rather than being changed in place and this is so huge. That said merge order is out of my hands anyway and this might be too big to be allowed to merge so who knows.
There was a problem hiding this comment.
Oh wow, yeah this is big. I can sort out the merge conflicts on my end easier than you can.
|
Yeah so you're right about this being gigantic. I've done stuff like this before where i went down a rathole, but you can usually get a feel for the smaller pieces that can be pulled out. I highly recommend you revisit this and cut it up into smaller chunks, and please remember: anything that invokes a uilist or a prompt should not be in Character but avatar, and do the necessary parts to fix that up if there's key logic in there. |
|
This pull request introduces 1 alert when merging dd28100 into b2532d1 - view on LGTM.com new alerts:
|
Summary
SUMMARY: Infrastructure "Migrate more functions from player to character"
Purpose of change
Part of #34721
Moving code from player to character
Describe the solution
Describe alternatives you've considered
I intended for this to be a much smaller PR but so many things are tied together that it was impossible to move them in smaller pieces.
Testing
Additional context