Added WINDOW flag to trunk doors #39933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "add WINDOW flag to trunk doors"Purpose of change
Trunk doors didn't have the
WINDOWflag, despite their description saying that we can see through them. It is now possible to install curtains on a trunk door, and make a vehicle with a trunk impermeable to light.Describe the solution
Added the
WINDOWflag todoor_trunkandhddoor_trunk.Describe alternatives you've considered
Not adding the flag if for some reason curtains can't be installed on trunk door windows.
Testing
I spawned a car and a humvee in game and could install curtains on their trunk doors.
Additional context
While looking through the flags I noticed that the
LOW_FINAL_AIR_DRAGandNO_ROOF_NEEDEDflags are used in the code but not documented indoc/JSON_FLAGS.md.