Fix overmap UI blinking on curses build #40375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're right that cataclysm itself consumes 3% CPU both before and after that change, but when it's blinking, there's additionally 12% consumption from X (at least when running it in urxvt). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Fixes #40248.
Describe the solution
Do not call
catacurses::erase()andcatacurses::refresh()before redrawing overmap.Testing
Compiled with MSYS2 ncurses and it does not blink now when taking input, which means it should also fix the blinking mentioned in #40248, though I'm not sure if it also fixes "spending my precious battery and heating my pants", because afaik overmap UI has always been completely redrawn when input times out even before migrating it to ui_adaptor.