Enable mouse input for uilist #41272
Conversation
mlangsdorf
added
the
Info / User Interface
src/inventory_ui.h
Outdated
| @@ -52,6 +52,14 @@ struct inventory_entry_drawn_info { | |||
| int text_x_start; | |||
| int text_x_end; | |||
| int y; | |||
| bool include_point( point p )const { | |||
| if( text_x_start <= p.x && | |||
There was a problem hiding this comment.
Would you please just put this all on one line? General CDDA practice is to put multiple conditions on a single line if the total line length is less than 100 characters.
There was a problem hiding this comment.
hah? but I saw many cases of mutiple lined if conditions
maybe I can add a parent class for all the drawn_infos? But I cannot touch computer in week days, further commit will be lagged until next weekend |
Co-authored-by: Mark Langsdorf <mark.langsdorf@gmail.com>
| } | ||
| return false; | ||
| } | ||
| struct inventory_entry_drawn_info : entry_drawn_info { |
There was a problem hiding this comment.
Why not use entry_drawn_info directly? This inheritance does not add anything to the parent class.
There was a problem hiding this comment.
in future there may be something added
There was a problem hiding this comment.
You can always create a new class in the future, but now it does nothing and only clutters up the code. And even if something is to be added in the future, I would recommend adding it to the parent class (any maybe guard it with a flag), so other UIs can also use the new functionality when they need to.
There was a problem hiding this comment.
I mean there are a lot of variant UI things in game, else than inventory and uilist, there are pickup, inventory_item_menu, crafting, and whatever, each of them are having different kind of drawing, its just this two drawn info structs are currently not different.
There was a problem hiding this comment.
besides, I am also considering to add some new things, such as button.
There was a problem hiding this comment.
I mean there are a lot of variant UI things in game, else than inventory and uilist, there are pickup, inventory_item_menu, crafting, and whatever, each of them are having different kind of drawing
And I'm pretty sure it's a bad thing we'd like to get rid of and have a unified system to display menu stuff instead.
| @@ -64,6 +64,9 @@ struct uilist_entry_drawn_info { | |||
| } | |||
| }; | |||
|
|
|||
| struct uilist_entry_drawn_info : entry_drawn_info { | |||
There was a problem hiding this comment.
because the way of drawing for those two kinds of UI thing are not exactly the same, currently the drawn info records are not necessary to to be variant yet, but maybe in future one of them is to be changed.
Co-authored-by: BevapDin <tho_ki@gmx.de>
Summary
SUMMARY: Features "Enable mouse input for uilist"
Purpose of change
This is further work based on #40794
As what I said, I am going to make mouse input available for other things in the game.
Describe the solution
Similar to what I have done in previous PR, I made a struct uilist_entry_drawn_info to record the information of drawing of the entries. Then I added another else if for SELECT input in void uilist::query( bool loop, int timeout ).
Describe alternatives you've considered
N/A
Testing
Windows10, VS, both release and debug build tested, all fine.
Additional context
Also optimized some codes done before.