Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Glitched 4th of July ascii art #41452

Merged
merged 5 commits into from
Jun 19, 2020
Merged

Conversation

BevapDin
Copy link
Contributor

@BevapDin BevapDin commented Jun 19, 2020

Fixes #40510.

SUMMARY: None

Remove special for for printing the main menu title with colors

Just let the title always be printed with color codes, regardless of the holiday.

Embed color codes in title/en.halloween, according to the way it was colored in the code in "main_menu.cpp". Essentially no changes to the displayed content.

Just let the title always be printed with color codes, regardless of the holiday.

Embed color codes in title/en.halloween, according to the way it was colored in the code in "main_menu.cpp".
Essentially no changes to the displayed content.
Copy link
Contributor

@ZhilkinSerg ZhilkinSerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is probably no need to color each character separately.

Don't need color tags for each individual character.
@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. labels Jun 19, 2020
@ZhilkinSerg ZhilkinSerg merged commit 23565d2 into CleverRaven:master Jun 19, 2020
@olanti-p
Copy link
Contributor

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glitched 4th of July ascii art
3 participants