Fix 40x53mm copy-from issues #42292
Merged
Fix 40x53mm copy-from issues #42292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
<Bugfix>
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
The volume field for 40x53 grenades was not put on the abstract round, leading to non-M1001 grenades being microscopically tiny. The casing and weight can also be moved to the abstract, since all of them use the M169 casing & weigh 340g.
Describe the solution
Move casing, volume, & weight to the abstract grenade.
Describe alternatives you've considered
None.
Testing
Spawn in every ammo type to view its volume, fire off a Mark 19 to see that casing is inherited from
copy-from.Additional context
Original bug(from devcord):
