Display actual bound keys in crafting gui #47584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
[C++]
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "Display actual bound keys in crafting gui"
Purpose of change
The keybindings tips in the crafting gui were hard-coded. Display actual bound keys instead.
Describe the solution
Generate and fold keybindings tips on the fly when initializing or resizing. Dynamically resize the recipe list and item info according to the line count of keybindings tips. Also made keybindings tips format consistent in wide and narrow modes.
Testing
Opened crafting gui and keybindings tips were correctly displayed. Resize the window and the tips were correctly folded and displayed.
Additional context
Recipe info is a bit messy with low screen height, which I intend to address in a separate PR by switching to scrolling instead of "mode cycling".