Allow skipping NPC rotation for tinymaps #47730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See CleverRaven#44978 for context. When farm_json in faction_camp.cpp calls generate(), it rotates to match the actual map it is supposed to correspond to. However, in doing this it shifts NPCs (e.g. from (62,67,0) to (9,4,0)), when it not actually having an effect on the map. This can cause NPCs to vanish when the description strings for faction camp missions are generated, as they generate the tinymap. As a quick fix for 0.F, skip the rotation. In the future, we should be looking at replacing the insane faction camp farming thing with a zone based system.
anothersimulacrum
added
<Bugfix>
This was referenced Sep 18, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Don't move NPCs around the map when generating faction camp UI"
Purpose of change
Fixes #44978
Describe the solution
When farm_json in faction_camp.cpp calls generate(), it rotates to match the actual map it is supposed to correspond to. However, in doing this it shifts NPCs (e.g. from (62,67,0) to (9,4,0)), when it not actually having an effect on the map. This can cause NPCs to vanish when the description strings for faction camp missions are generated, as they generate the tinymap.
As a quick fix for 0.F, skip the rotation. In the future, we should be looking at replacing the insane faction camp farming thing with a zone based system.
Testing
Load the save from the linked issue, examine the bulletin board. NPCs no longer teleport around the map.