Limit feral humans ammo #47754
Merged
Limit feral humans ammo #47754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wapcaplet
added
<Bugfix>
Maleclypse
requested changes
Feb 27, 2021
| "ammo_effects": [ "NO_PENETRATE_OBSTACLES" ], | ||
| "clip_size": 1, |
There was a problem hiding this comment.
Make that six rocks, please.
There was a problem hiding this comment.
Are you sure? It's not ammo count, and a slingshot has the same clip_size of 1. The ammo count is defined as starting_ammo in monster definition and is set to 6. According to my testing, feral humans are now correctly limited to six rocks, with no visible side effects.
There was a problem hiding this comment.
Sorry I was confused. I’ll figure out how to change my review. Thanks for fixing this.
Maleclypse
approved these changes
Feb 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Prevents
feral humanmonsters from having unlimited rocks to throw. Fixes #42169Describe the solution
Minor json changes to both the monster and its (fake) gun definition.
Testing
Start with an evac shelter and edit the map to replace the (closed) ladder door with metal bars (t_bars). Summon a
feral humanmonster there. Check if the monster throws exactly six stones at you, as is intended.Additional context
Feral humans have a
NO_PENETRATE_OBSTACLESammo effect that prevents their projectiles from passing through transparent, but impassable terrains, like bars. This seems to be unique to the monster and I'm not sure if this is their intended behavior.