Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing shape of vehicle parts without reinstalling #48477

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

Saicchi
Copy link
Contributor

@Saicchi Saicchi commented Apr 11, 2021

Summary

Interface "Allow changing shape of vehicle parts without reinstalling"

Purpose of change

Vehicle parts shape and orientation are purely comestic, but you can't change them without uninstalling and installing the part.

Describe the solution

Add a new menu to the vehicle examine menu, shaPe. It allows the player to change the shape instantly free of cost.

Describe alternatives you've considered

Make the menu return to the base state after changing shape. This speeds up things if players want to change the shape of parts on different tiles.

Testing

  • Changing shape is purely comestic and does not affect the vehicle at all

Additional context

It was my first time dealing with the vehicle code, it's confusing how it all works, and since I don't know what to expect from changing the vehicle part variant, I might have messed up in vpart_shapes, though at the moment it seems to be working fine.

I wanted to pick a key closer to ESC but s, a and e were taken, so I went with p instead of h.

092301
092250

@BrettDong BrettDong added Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` Vehicles Vehicles, parts, mechanics & interactions labels Apr 11, 2021
@actual-nh actual-nh added 0.F String Freeze <Enhancement / Feature> New features, or enhancements on existing labels Apr 12, 2021
@jagoly
Copy link
Contributor

jagoly commented Apr 12, 2021

IMO making shape changes should take a small amount of time, something like 1/4 of the install time. I think this would feel better for players, like they are actually modifying the vehicle, even if it is just to look cooler.

@Saicchi
Copy link
Contributor Author

Saicchi commented Apr 12, 2021

That adds unnecessary complexity for a function that has no impact in-game and is purely cosmetic.

@I-am-Erk I-am-Erk merged commit 8d81a7e into CleverRaven:master Jul 9, 2021
@Saicchi Saicchi deleted the vehicleshape branch July 9, 2021 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc. Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants