Add option to raise the visor to motorcycle helmet #48560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-nh
added
0.F String Freeze
<Enhancement / Feature>
actual-nh
reviewed
Apr 18, 2021
Salty-Panda
force-pushed
the
add_visor_to_motorcycle_helmet
branch
from
dea5fea
to
996a928
Compare
Salty-Panda
requested review from
BrettDong,
Fris0uman,
I-am-Erk,
John-Candlebury,
KorGgenT,
Maleclypse and
Mom-Bun
as code owners
ZhilkinSerg
force-pushed
the
0.F-dev
branch
2 times, most recently
from
11f8b39
to
a3ed94b
Compare
anothersimulacrum
removed request for
John-Candlebury,
BrettDong,
KorGgenT,
Fris0uman,
Mom-Bun,
I-am-Erk and
Maleclypse
ZhilkinSerg
force-pushed
the
0.F-dev
branch
3 times, most recently
from
ac1984a
to
c8f13cf
Compare
|
Please open a new PR for this targeting the experimental branch. Was closed as a side effect of deleting the 0.F -dev branch |
|
Hmm, that's really weird, I didn't delete anything. I don't know why it's saying that was me who deleted the branch. |
Copies entire entry, replace using copy-from once CleverRaven#43144 will get merged
Salty-Panda
force-pushed
the
add_visor_to_motorcycle_helmet
branch
from
996a928
to
23d610f
Compare
|
Rebased |
Salty-Panda
commented
Aug 14, 2021
Maleclypse
approved these changes
Aug 15, 2021
| "material_thickness": 6, | ||
| "armor": [ | ||
| { "covers": [ "head" ], "coverage": 100, "encumbrance": 25 }, | ||
| { "covers": [ "eyes" ], "coverage": 100, "encumbrance": 5 }, |
There was a problem hiding this comment.
I don't know if it's possible to set an material thickness specifically for one section, I'd think this would have 1 or 2 thickness when visor down over the eyes. But again not sure that's how it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Add option to raise the visor to motorcycle helmet"
Purpose of change
You should be able to raise the visor
Describe the solution
The new item motorcycle_helmet_raised copies entire entry, replace using copy-from once #43144 will get merged
Describe alternatives you've considered
none
Testing
Tested values in-game