-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Magiclysm] Can't cast if Stunned #48651
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-nh
added
0.F Feature Freeze
<Bugfix>
This is a fix for a bug (or closes open issue)
Mods: Magiclysm
Anything to do with the Magiclysm mod
labels
Apr 25, 2021
Salty-Panda
force-pushed
the
Nerf_spellcasting
branch
from
May 3, 2021 15:04
6654678
to
23fef74
Compare
Salty-Panda
requested review from
BrettDong,
Fris0uman,
I-am-Erk,
John-Candlebury,
Maleclypse and
Mom-Bun
as code owners
May 28, 2021 10:06
ZhilkinSerg
force-pushed
the
0.F-dev
branch
2 times, most recently
from
May 31, 2021 07:49
11f8b39
to
a3ed94b
Compare
anothersimulacrum
removed request for
John-Candlebury,
BrettDong,
Fris0uman,
Mom-Bun,
I-am-Erk and
Maleclypse
June 5, 2021 18:50
ZhilkinSerg
force-pushed
the
0.F-dev
branch
3 times, most recently
from
June 14, 2021 15:06
ac1984a
to
c8f13cf
Compare
This might be an easy merge if it's rebased onto Master and edited to target master as well. |
Salty-Panda
force-pushed
the
Nerf_spellcasting
branch
from
July 11, 2021 09:59
23fef74
to
120d53f
Compare
Rebased on master, cleared conflicts |
ZhilkinSerg
added a commit
to ZhilkinSerg/Cataclysm-DDA
that referenced
this pull request
Aug 12, 2021
ZhilkinSerg
added a commit
that referenced
this pull request
Aug 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
<Bugfix>
This is a fix for a bug (or closes open issue)
Mods: Magiclysm
Anything to do with the Magiclysm mod
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[Magiclysm] Can't cast if Stunned"
Purpose of change
After being hit by a riot control platform you can't move in a straight line but can cast high difficulty lighting bolts and teleports?
Describe the solution
Check if the character is stunned before casting a spell if it requires hands
It's a compromise since most mutation spells like Dragon's Breath etc. have this flag and I consider them to be rather instinctual.
Describe alternatives you've considered
Trying to decide what spells are "instinctual" vs "trained"
Testing
Can't cast a spell if stunned
Can use magic items
Can cast a no-hands spell