Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make contents member of item class private final part #50138

Merged
merged 10 commits into from
Jul 23, 2021
Merged

Make contents member of item class private final part #50138

merged 10 commits into from
Jul 23, 2021

Commits on Jul 22, 2021

  1. wrappers for item_contents::first_ammo and item_contents::get_item_wi… 

    …th in item
    mqrause committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    dbd0913 View commit details
    Browse the repository at this point in the history

  2. wrappers for item_contents::handle_liquid_or_spill and item_contents:… 

    …:total_contained_volume in item
    mqrause committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    33905d9 View commit details
    Browse the repository at this point in the history

  3. replace calls to some item_contents methods with their item counterparts

    mqrause committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    c830345 View commit details
    Browse the repository at this point in the history

  4. use item::put_in instead of item_contents::insert_item

    mqrause committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    d3973fd View commit details
    Browse the repository at this point in the history

  5. wrappers for item_contents::force_insert_item and item_contents::comb… 

    …ine in item
    mqrause committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    8a989fb View commit details
    Browse the repository at this point in the history

  6. - remove item_contents::sealed_summary and the sealed_summary enum 

    - add item_contents::all_pockets_sealed and item_contents::any_pockets_sealed and wrappers for them in item
    mqrause committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    c3bb5eb View commit details
    Browse the repository at this point in the history

  7. wrappers for item_contents::visit_contents and item_contents::remove_… 

    …internal in item
    mqrause committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    d0435ed View commit details
    Browse the repository at this point in the history

  8. use item::get_remaining_capacity_for_liquid instead of item_contents:… 

    …:remaining_capacity_for_liquid
    mqrause committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    0f0ff9d View commit details
    Browse the repository at this point in the history

  9. remove uses of item_contents::remaining_container_capacity in reloadi… 

    …ng_test.cpp and item_contents::remove_item_if in item_contents_test.cpp
    mqrause committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    9bf9545 View commit details
    Browse the repository at this point in the history

  10. private contents member and remove most item_contents.h includes

    mqrause committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    e1a3575 View commit details
    Browse the repository at this point in the history