Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more player to character #50477

Merged
merged 8 commits into from
Aug 10, 2021
Merged

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented Aug 4, 2021

Summary

Infrastructure "Move more player to character"

Purpose of change

Remove player class

Describe the solution

Only change to the moved code is the final commit which is a small change to prevent clang warning about divide by zero error.

Describe alternatives you've considered

Testing

Additional context

@actual-nh actual-nh added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Aug 4, 2021
@Ramza13 Ramza13 force-pushed the migrate_player branch 2 times, most recently from 5e4164b to ffc4a9a Compare August 9, 2021 18:41
src/player.cpp Outdated Show resolved Hide resolved
@kevingranade kevingranade merged commit 37171ba into CleverRaven:master Aug 10, 2021
@Ramza13 Ramza13 deleted the migrate_player branch August 11, 2021 02:22
satheon49 pushed a commit to satheon49/Cataclysm-DDA that referenced this pull request Aug 14, 2021
Co-authored-by: Kevin Granade <kevin.granade@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants