Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "Move position into Creature"
Purpose of change
The
position
field and related getters and setters are duplicated inCharacter
andmonster
, the 2 subclasses ofCreature
.Describe the solution
Remove the duplication by moving the code into creature.h. Also
position
is now protected.Monster
,Character
andnpc
still overridesetpos()
in order to do other stuff, but now they call the superclass'setpos()
instead of modifying the position directly.Describe alternatives you've considered
Going one step further by making
position
private. Would need to fix many references to usepos()
instead.Testing
For the save/load code: loaded an existing save made prior to the change, got no errors. Spawned a monster and an NPC, saved and loaded again to verify they didn't teleport.
Additional context