Fix for WEBWALK flag #50760
Merged
Fix for WEBWALK flag #50760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds code to is_immune_field() for handling WEBWALK flag
actual-nh
added
<Bugfix>
|
Ping: @Venera3? |
actual-nh
reviewed
Aug 14, 2021
Co-authored-by: actual-nh <74678550+actual-nh@users.noreply.github.com>
actual-nh
reviewed
Aug 14, 2021
Co-authored-by: actual-nh <74678550+actual-nh@users.noreply.github.com>
Maleclypse
approved these changes
Aug 14, 2021
|
There's an (obviously broken) bit in |
BrettDong
added a commit
that referenced
this pull request
Nov 27, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
Nov 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds code to is_immune_field() for handling WEBWALK flag
Summary
Bugfixes "WEBWALK flag works now"
Purpose of change
Fixes #50654 and Fixes #48639
Describe the solution
Added a couple lines to is_immune_field() within monmove.cpp. There just wasn't any code to handle the specific immunity before.
Describe alternatives you've considered
This was my first dive into Cata's C++ and you don't need to know how long it took me to find the relevant function. This is the only solution I could find, but as far as I can tell it's the right one.
Testing
I first tested the bug in the latest experimental to make sure it's properly broken. Spawned in one of those spider web forest things and a clairvoyance artifact so I could see, and watched as all the sad giant mutant spiders struggled in their own webs.
Then I compiled a new build with my new code and did the same thing there. All the spiders rushed out to kill me horribly, totally unobstructed by their own webs as hoped. Those big web areas should be substantially more dangerous now.
I specifically spawned in several different kinds of spider, including Magiclysm's Demon Spider, to make sure everyone got to come along for the horrible, spidery ride.
Additional context