Refactor: stop duplicating information in the character creation

[hexagonrecursion]

Summary

Bugfixes "Fix all the bugs with character creation point pools forever"

Purpose of change

Fixes #50665

Currently the character creation menu tries (and sometimes fails) to keep two pieces of information in sync: the point pools and the choices the player made. This leads to bugs like #50665.

Describe the solution

I propose to recompute the point pools where needed instead of keeping them in a variable and updating them in-place. This should be much less code and remove many opportunities for bugs.

Testing

Opened the character creation menu and played around with it a but. Observations so far:

• Because choosing a scenario currently always resets profession to the default profession for the scenario it may look as if some scenarios cost more or fever points then they say they do. What actually happens is that the cost of the profession applied as soon as the scenario is selected.

[kevingranade]

I absolutely love your approach here, this centralizes all the evaluation in a really nice way so it's easier to get a view into how things interact with each other, and also pulls code out of avatar and character, which is great.

[hexagonrecursion]

Master is green. I want to take the opportunity to CI this. Close and reopen.