Migrate pickup menu to a new inventory_multiselector menu

[mqrause]

Summary

Interface "New pickup menu able to handle containers and their contents"

Purpose of change

The old pickup menu is unfit for the pocket system and also a general pain.

Describe the solution

• make a pickup menu using inventory_multiselector that can pick items from the surrounding map/vehicles
• remove all directional pickup functionality (examine and "pick up at feet")
• remove WORKBENCH_ALL_OPTIONS external option
• allow custom invlet solutions for menus using inventory_selector
• pickup_inventory_preset hides ammo from ammo belts
• pickup_inventory_preset only checks weight of a single charge to determine if an item is too heavy. This can possibly have negative consequences, but the alternative would be not being able to select a stack that's too big at all. Handling items with charges is still generally problematic.

This does not remove or clean up Pickup::pickup because a) that's still used by autopickup and b) I'm too low on time right now to sort through all that.

Describe alternatives you've considered

Make a directional version of the new menu instead of removing pickup functionality from examine and pick up at feet.

Testing

I played with this for a bit. I'm relatively sure there's still some special cases I missed that might cause strange behavior, but it should be good enough for now.

Additional context

[Night-Pryanik]

remove all directional pickup functionality (examine and "pick up at feet")

While personally I'm not against it, many other players will hate this change because of muscle memory.

[mqrause]

While personally I'm not against it, many other players will hate this change because of muscle memory.

Ha, yeah, I hate myself already, but I still think it's the better option. I'm not against reverting that, though.

[mqrause]

Since 0-9 as hotkeys for selection didn't work and it's stupid anyway, I allowed a flexible solution for menus now and made a simplified version of what was in the old pickup menu. It seems the input_context forbids a few too many keys (see screenshot)?

[mqrause]

@Night-Pryanik
What's your opinion on removing the WORKBENCH_ALL_OPTIONS external option? Since this will remove pickup functionality from examine anyway, I think it's not needed anymore? I also found it quite confusing until I realized that was what changed workbench examination when using No Hope.

[Night-Pryanik]

@mqrause if the pickup functionality will be removed from examine menu, I'm fine with removing this external option.

[ghost]

Not having directional pickup ability makes the game unplayable for me personally. I'm forced to rollback as having to scroll through several pages of items to figure out which tile has what is too painful.

[Aphegis]

Everyone already knows this, but I'm explaining the problem in case someone played it differently (something I'm noticing after reading some comments, some players used 'g', some 'e').

This is an exaggerated situation (common if you have a small base with many items close together, even after managing 'Y' zone (shift + y).

Previously, I would press 'V' (shift + v), so I could scan the area in a few seconds and see if I found something good, then press 'e' + arrow keys to select the item's position.

Currently you don't have the option to select tiles specifically, so when you press 'g' with too many items around you, it becomes confusing and inefficient.

Character surrounded by items

Current 'g' interface

Obviously devs are already aware of this, but i must say, highly controversial change, specially given the fact that current 'g' does not 100% substitutes the previous 'e'.

[wapcaplet]

Agreed; I must strongly object to this new g menu not taking a directional input. The previous get, as well as Grab, Drop, examine, smash, open, and close commands all take a direction, and it is bizarre for the new interface to skip that.

Edit I have submitted a fix to restore the directional selector: #52683

[Zhid13]

I see absolutely no upside to this new update. It removes functionality and replaces it with nothing. It is mentioned that the previous system was a "pain" to use with the pocket system, however the new one does not offer any novel function regarding said pocket system.

Not only does this affect ease of looting around but it also interferes with the a menu, as objects inside a container which contents are hidden are unusable through that menu. And ironically another issue that has cropped up is that objects inside containers that are themselves contained in pockets show up when pressing i, needlessly cluttering the inventory and overriding the decision you've taken to hide a container's contents, and adding the need to do the same for every container within.

Objects appear disordered, and container's contents don't appear next to them, merely referencing their container by highlighting it, which is disappointing considering the new feature is supposed to work better with pockets. And on top of that the ; command to categorize everything by item categories is broken as well, losing a piece of functionality that could put at least some order in the very ugly looking list of all items spread over your surrounding tiles.

[mqrause]

Not only does this affect ease of looting around but it also interferes with the a menu, as objects inside a container which contents are hidden are unusable through that menu. And ironically another issue that has cropped up is that objects inside containers that are themselves contained in pockets show up when pressing i, needlessly cluttering the inventory and overriding the decision you've taken to hide a container's contents, and adding the need to do the same for every container within.

Objects appear disordered, and container's contents don't appear next to them, merely referencing their container by highlighting it, which is disappointing considering the new feature is supposed to work better with pockets. And on top of that the ; command to categorize everything by item categories is broken as well, losing a piece of functionality that could put at least some order in the very ugly looking list of all items spread over your surrounding tiles.

This has nothing to do with this PR. I changed nothing about the menu behavior. The ; thing is worth looking into, though.

[Zhid13]

I apologize for jumping to conclusions so quickly. I have done more testing and filed the proper report.

[Shinoskay]

I was directed to here to give feed back about the experimental modes pick up interface.

So, the experimental mode seems really un intuitive compared to the previous one. In stable, its really easy to right click pick up items and if there are other functions on the spot then it gives you a list with get items as one of them. I literally just started two days ago and can assure you that the previous system is much more functional and better than the new system. Which is really clunky (metaphorically speaking, of course).

I am specifically referring to the right click functionality when interacting/interfacing with items on the ground.

[mqrause]

Please make a separate issue about this, describing the functionality you miss in a bit more detail.