Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DinoMod] make faction base safer #51040

Merged
merged 4 commits into from
Sep 26, 2021
Merged

[DinoMod] make faction base safer #51040

merged 4 commits into from
Sep 26, 2021

Conversation

LyleSY
Copy link
Contributor

@LyleSY LyleSY commented Aug 24, 2021

Summary

Mods "make DinoMod faction base safer"

Purpose of change

Make DinoMod NPC faction survive longer

Describe the solution

Changes Swamper faction location to use more secure windows and adds two more guards, cuts a bunch of redundant lines.

Describe alternatives you've considered

Stick them in an LMOE shelter in the middle of nowhere like Aftershock does, move the Swamper church location to an out of town special like was done with the dino exhibit, put them in a larger location with more buffer like the shelter.

Testing

Game loads no errors, windows look right
Screen Shot 2021-09-24 at 6 22 35 PM

Additional context

Thanks to Fishe on Discord for the bug report

@LyleSY LyleSY added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) labels Aug 24, 2021
@actual-nh
Copy link
Contributor

It may be a good idea to make them into an overmap special and give them the SAFE_AT_WORLDGEN flag; see #49377.

@LyleSY
Copy link
Contributor Author

LyleSY commented Sep 23, 2021

Agreed, but I don't have time to make that happen in the near future, going with the minimal fix for now to wrap this up

@LyleSY LyleSY marked this pull request as ready for review September 24, 2021 22:23
@kevingranade kevingranade merged commit ab32a12 into master Sep 26, 2021
@kevingranade kevingranade deleted the LyleSY-patch-2 branch September 26, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants