Parametric mapgen part 8: Support mapgen parameters for more mapgen ids #51076
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "Brief description"
Purpose of change
Continuing the work of #50853. After that PR, there were five remaining things to have
mapgen_value
support added to them.Describe the solution
This PR completes three of them:
jmapgen_gaspump
's fuel typejmapgen_monster
's monster idsjmapgen_sealed_item
's furniture idAncillary changes needed for this:
itype_id
rather than simply a string.Describe alternatives you've considered
Doing this as more or fewer PRs.
Testing
I caused the generation of at least one OMT featuring each type changed (military helipad for the gaspump, lab basement for the monster placement, farm field for the sealed_item). They all seemed to work as expected.
Additional context
Two things remain to be ported and are put off again to a future PR:
jmapgen_item_group
's item groupjmapgen_loot
's result_groupThey will be the most complicated ones to deal with.