Adds missing knives to the Krav Maga list #51131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds missing knives to the Krav Maga list. Considering some of the ones already on the list, such as makeshift and bone knives, ones like the kukri should all definitely be included as well
RandDenner
changed the title
actual-nh
added
<Bugfix>
|
This might no longer be needed, or may be doable in a better way - see #50212, which just merged. |
Yes, it looks like it, once all the various weapon .json files are updated with the weapon categories. |
Missed a comma. Oops!
No, I forgot to MOVE a comma. Dumb
Venera3
pushed a commit
to Venera3/Cataclysm-DDA
that referenced
this pull request
Sep 21, 2021
* Add files via upload Adds missing knives to the Krav Maga list. Considering some of the ones already on the list, such as makeshift and bone knives, ones like the kukri should all definitely be included as well * Update martialarts.json Missed a comma. Oops! * Update martialarts.json No, I forgot to MOVE a comma. Dumb
BrettDong
added a commit
that referenced
this pull request
Nov 27, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
Nov 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Adds missing knives to the Krav Maga list"
Purpose of change
Fixes #51015
Verisimilitude, and meeting expectations of players that similar bladed weapons should all be usable with the martial art. Considering some of the ones already on the list, such as makeshift and bone knives, ones like the kukri should all definitely be included as well.
Describe the solution
Add the missing combat capable knives to the list.